Skip to content

Add new archetype for custom landing page #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 24, 2025
Merged

Add new archetype for custom landing page #668

merged 8 commits into from
Jun 24, 2025

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Jun 11, 2025 •
edited by ADubhlaoich
Loading

Proposed changes

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this Jun 11, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner June 11, 2025 10:19
@lamATnginx lamATnginx added the enhancement New feature or request label Jun 11, 2025
@lamATnginx lamATnginx requested review from a team as code owners June 11, 2025 10:19
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console tooling Back end, repository, Hugo, and all things not related to content product/nap-waf NGINX App Protect WAF labels Jun 11, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/668/

@lamATnginx lamATnginx requested a review from a team as a code owner June 11, 2025 14:19
@github-actions github-actions bot added the product/ngf Issues related to NGINX Gateway Fabric label Jun 11, 2025
@ADubhlaoich ADubhlaoich removed request for a team June 12, 2025 08:16
@lamATnginx lamATnginx marked this pull request as draft June 12, 2025 08:41
@ADubhlaoich
Copy link
Contributor

I will push changes for the archetype directly into this branch later today or early tomorrow.

@ADubhlaoich ADubhlaoich marked this pull request as ready for review June 23, 2025 11:53
@ADubhlaoich ADubhlaoich marked this pull request as draft June 23, 2025 11:53
ADubhlaoich
ADubhlaoich approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM: I pushed a number of commits directly into the branch to keep the guidance in line with the other archetypes.

I have been corresponding with Lam on how some of these changes (Such as the frontmatter parameters) will need to be reflected in the theme.

@ADubhlaoich ADubhlaoich marked this pull request as ready for review June 23, 2025 15:41
ADubhlaoich
ADubhlaoich reviewed Jun 24, 2025
View reviewed changes
@ADubhlaoich ADubhlaoich merged commit a50ded8 into main Jun 24, 2025
10 checks passed
@ADubhlaoich ADubhlaoich deleted the landing-archetype branch June 24, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@travisamartin travisamartin travisamartin approved these changes

Assignees

@lamATnginx lamATnginx

Labels
documentation Improvements or additions to documentation enhancement New feature or request product/nap-waf NGINX App Protect WAF product/ngf Issues related to NGINX Gateway Fabric product/nginx-one NGINX One Console tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lamATnginx @ADubhlaoich @travisamartin @mjang